Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced accountname.visualstudio.com with dev.azure.com/accountname #93

Merged
merged 54 commits into from
Sep 17, 2018

Conversation

KaiWalter
Copy link
Contributor

PR Summary

  • replaced accountname.visualstudio.com with dev.azure.com/accountname
  • aligned subdomain build url
  • aligned tests
  • executed all units and integration tests successfully (for VSTS)

PR Checklist

Sorry, something went wrong.

KaiWalter and others added 30 commits July 26, 2018 22:14
Can navigate build defs for TFS and VSTS
@KaiWalter KaiWalter mentioned this pull request Sep 15, 2018
4 tasks
@DarqueWarrior
Copy link
Collaborator

DarqueWarrior commented Sep 15, 2018

You have to make sure this code still works with old profiles. For example, if I already have a profile called 'test' and the URL is 'test.vsiualstudio.com'. If I were to try and run Add-Profile for 'test' again the original entry should be updated to 'dev.azure.com/test' but instead, I get two entries both named 'test' with two different URLs.

Instead of changing the 'test.visualstudio.com' entry to 'dev.azure.com/test' in the $contents var in profiles.Tests.ps1 you needed to add a new entry leaving the old one as well. Then test updating them both to make sure old profiles can still be used.

We can't expect people to not be able to use their old profiles.

@KaiWalter
Copy link
Contributor Author

OK, I see. I look into this.

@KaiWalter
Copy link
Contributor Author

@DarqueWarrior handled old URLs in profile and added unit tests to verify the conversion from old to new in profile

@DarqueWarrior DarqueWarrior merged commit fe4b824 into MethodsAndPractices:master Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants